Re: [PATCHES] libpq type system 0.9a

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Andrew Chernow <ac(at)esilo(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Martijn van Oosterhout <kleptog(at)svana(dot)org>, Greg Sabino Mullane <greg(at)turnstep(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCHES] libpq type system 0.9a
Date: 2008-04-09 00:24:11
Message-ID: 47FC0CAB.702@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Andrew Chernow wrote:
> Andrew Chernow wrote:
>>>
>>> When I say I'd accept some hooks into libpq, I mean some hooks that
>>> could be used by either libpgtypes or something that would like to do
>>> something roughly similar but with a different API offered to clients.
>>> The particular hook that you seem to mostly need is the ability to
>>> allocate some private memory associated with a particular PGconn
>>> object,
>>> and maybe also with individual PGresults, and then to be able to free
>>> that at PQclear or PQfinish. Try designing it like that.
>>>
>>> regards, tom lane
>
> Your method would work as well. The only issue is you still have the
> same issue of binary distributed libpqs. Would redhat distribute a
> binary linked with libpqtypes? If not, you have the same issue of the
> end-user having to compile libpq ... passing -lpqtypes to the linker.
> If redhat did link it, you run into the disk space complaint all over
> again.
>
> My suggestion was trying to work around this by dynamically loading
> the library, PQtypesEnable(TRUE). In this model, redhat doesn't even
> have to distribute libpqtypes.so (considering the disk space issue).
> It could be easily be an additional download. All you need are some
> proxy functions inside libpq, PQputf calling a dynamically loaded
> function. This passes the disk space complaints and doesn't require a
> re-compile if an end-user wants to use it.
>
>

Why would RedHat need to know anything at all about libpqtypes? AIUI Tom
is suggesting an API that in libpq that libpqtypes or some other library
could use, but not that libpq would be linked against libpqtypes at all.

cheers

andrew

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Josh Berkus 2008-04-09 00:24:15 Calling GSoc Mentors
Previous Message Andrew Chernow 2008-04-09 00:09:28 Re: [PATCHES] libpq type system 0.9a

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2008-04-09 00:25:40 Re: [PATCHES] libpq type system 0.9a
Previous Message Andrew Chernow 2008-04-09 00:09:28 Re: [PATCHES] libpq type system 0.9a