From: | Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> |
---|---|
To: | Bruce Momjian <bruce(at)momjian(dot)us> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: Headers dependencies cleanup |
Date: | 2008-04-07 11:08:35 |
Message-ID: | 47FA00B3.4050600@sun.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
Bruce Momjian napsal(a):
> Zdenek Kotala wrote:
>> Tom Lane napsal(a):
>>> Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> writes:
>>>>>> During my work I found some header files, which include useless headers
>>>>>> and on other way there are some headers which silently assume that
>>>>>> requested header will be included by some other headers file.
>>>>> Bruce periodically runs a script that's supposed to catch this type
>>>>> of problem. Maybe we are overdue for another run?
>>>> Yes, but This problem is there for long time and I think Bruce's script does not
>>>> catch it.
>>> Exactly what problem do you see that he didn't catch?
>> bufpage.h includes bufmgr.h, but bufpage.h does not require any definition from
>> bufmgr.h. I think this dependency is there for long time.
>
> My scripts should have found this issue, see
> src/tools/pginclude/pgrminclude.
>
I'm going to try it and examine output.
Zdenek
From | Date | Subject | |
---|---|---|---|
Next Message | Kenneth Marshall | 2008-04-07 13:29:51 | Re: updated hash functions for postgresql v1 |
Previous Message | Tom Dunstan | 2008-04-07 10:46:37 | Re: [HACKERS] Database owner installable modules patch |