Re: actualised execute using patch

From: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: pgsql-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: actualised execute using patch
Date: 2008-03-25 12:55:27
Message-ID: 47E8F63F.2070409@sun.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

you have extra space onPavel Stehule napsal(a):
> Hello
>
> http://archives.postgresql.org/pgsql-patches/2007-10/msg00161.php
>
> I actualized this patch for current CVS

Hi Pavel,

I tested your patch and it works regarding to proposal. However
I have some small comments:

1) you have extra space in ./src/pl/plpgsql/src/gram.y on line 1351

2) there is some Czech text in regression tests diffs

3) I would like to add two more tests:

a) test which check if execute really takes 3rd parameter and inject it as a
first one:

create or replace function test(int,int,int) returns int as $$
declare
a int;
begin
execute 'select $1' into a using $3;
return a;
end
$$ language plpgsql;
select test(1,2,3);

b) and second test which control number of arguments:

for example:

create or replace function test(int,int,int) returns int as $$
begin
execute 'select $3' into a using $1;
return a;
end
$$ language plpgsql;
select test(1,2,3);

Zdenek

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Alvaro Herrera 2008-03-25 14:15:19 Re: Re: int8/float8/time/timestamp[tz]/float4 passed by value, was Re: Fix HAVE_LONG[_LONG]_INT_64 to really define to 1
Previous Message Martin Pihlak 2008-03-25 12:16:38 Re: stored procedure stats in collector