Re: pgsql: Enable probes to work with Mac OS X Leopard and other OSes that

From: Robert Lor <Robert(dot)Lor(at)Sun(dot)COM>
To: Peter Eisentraut <petere(at)postgresql(dot)org>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Enable probes to work with Mac OS X Leopard and other OSes that
Date: 2008-03-18 21:18:41
Message-ID: 47E031B1.7070902@sun.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Peter Eisentraut wrote:
> Modified Files:
> --------------
> pgsql/src/backend:
> Makefile (r1.127 -> r1.128)
> (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/Makefile?r1=1.127&r2=1.128)
> pgsql/src/backend/access/transam:
> xact.c (r1.259 -> r1.260)
> (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/transam/xact.c?r1=1.259&r2=1.260)
> pgsql/src/backend/storage/lmgr:
> lock.c (r1.182 -> r1.183)
> (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/storage/lmgr/lock.c?r1=1.182&r2=1.183)
> lwlock.c (r1.50 -> r1.51)
> (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/storage/lmgr/lwlock.c?r1=1.50&r2=1.51)
> pgsql/src/backend/utils:
> Makefile (r1.26 -> r1.27)
> (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/Makefile?r1=1.26&r2=1.27)
> pgsql/src/include:
> Makefile (r1.23 -> r1.24)
> (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/Makefile?r1=1.23&r2=1.24)
> c.h (r1.223 -> r1.224)
> (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/c.h?r1=1.223&r2=1.224)
> pg_trace.h (r1.3 -> r1.4)
> (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/pg_trace.h?r1=1.3&r2=1.4)
>
> Added Files:
> -----------
> pgsql/src/backend/utils:
> Gen_dummy_probes.sed (r1.1)
> (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/Gen_dummy_probes.sed?rev=1.1&content-type=text/x-cvsweb-markup)
>
>
You didn't include the changes in pgsql/src/Makefile. By generating
probes.h before the compile starts, it will allow probes to be added
outside the backend without having to do anything extra. Is this not the
right way or you think it's not needed now?

Regards,
-Robert

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Lor 2008-03-18 21:21:17 Re: [COMMITTERS] pgsql: Enable probes to work with Mac OS X Leopard and other OSes that
Previous Message Robert Lor 2008-03-18 20:59:08 Re: [COMMITTERS] pgsql: Enable probes to work with Mac OS X Leopard and other OSes that

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Lor 2008-03-18 21:21:17 Re: [COMMITTERS] pgsql: Enable probes to work with Mac OS X Leopard and other OSes that
Previous Message Robert Lor 2008-03-18 20:59:08 Re: [COMMITTERS] pgsql: Enable probes to work with Mac OS X Leopard and other OSes that