Re: Permanent settings

From: Josh Berkus <josh(at)agliodbs(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Dimitri Fontaine <dfontaine(at)hi-media(dot)com>, pgsql-hackers(at)postgresql(dot)org, Magnus Hagander <magnus(at)hagander(dot)net>, Gregory Stark <stark(at)enterprisedb(dot)com>, Csaba Nagy <nagy(at)ecircle-ag(dot)com>, Aidan Van Dyk <aidan(at)highrise(dot)ca>
Subject: Re: Permanent settings
Date: 2008-02-20 18:07:40
Message-ID: 47BC6C6C.8060708@agliodbs.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Magnus, all:

Other thoughts:

1) fix category display for pg_settings. 'nuff said.

2) allow *commenting* of pg_settings / SET PERMANENT. Thus:

SET PERMANENT work_mem = '12mb' COMMENT '16mb too high; OOM';

SET

SELECT name, comment FROM pg_settings WHERE name = 'work_mem';

work_mem | 16mb too high; OOM

3) We should also discuss potentially having "changed_on", "changedby" data:

SELECT name, changedon, changedat, changedby FROM pg_settings;

work_mem | 2008-01-22 14:35:11 | postgres
shared_buffers | 2008-01-20 13:11:11 | postgresql.conf file

(for "postgresql.conf file" the changedon would always be the date of
the last reboot)

4) We'll need a log setting for "log SET", since I can see people
wanting to log this kind of activity without necessarily logging all
statements.

--Josh Berkus

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2008-02-20 18:27:25 Re: Permanent settings
Previous Message Josh Berkus 2008-02-20 17:56:50 Re: Permanent settings