| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Marko Kreen <markokr(at)gmail(dot)com>, "Dr(dot) Andreas Kunert" <kunert(at)cms(dot)hu-berlin(dot)de>, Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Feature request: Logging SSL connections |
| Date: | 2014-01-17 15:53:50 |
| Message-ID: | 4703.1389974030@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Magnus Hagander <magnus(at)hagander(dot)net> writes:
> Applied, thanks!
Minor bikeshedding: the messages would read better, to my eye, as
"user=%s database=%s SSL enabled (protocol=%s, cipher=%s)"
Putting "enabled" where it is requires extra mental gymnastics on
the part of the reader. And why the random change between "="
in one part of the string and ": " in the new part? You could take
that last point a bit further and make it
"user=%s database=%s SSL=enabled (protocol=%s, cipher=%s)"
but I'm not sure if that's an improvement.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hannu Krosing | 2014-01-17 16:18:42 | Re: [Lsf-pc] Linux kernel impact on PostgreSQL performance |
| Previous Message | Tom Lane | 2014-01-17 15:44:41 | Re: Funny representation in pg_stat_statements.query. |