| From: | "Zeugswetter Andreas DAZ SD" <ZeugswetterA(at)spardat(dot)at> |
|---|---|
| To: | "Magnus Hagander" <mha(at)sollentuna(dot)net>, "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us> |
| Cc: | "PostgreSQL-development" <pgsql-hackers(at)postgresql(dot)org>, <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: [PATCHES] Open Items |
| Date: | 2004-11-02 13:20:45 |
| Message-ID: | 46C15C39FEB2C44BA555E356FBCD6FA40184D20F@m0114.s-mxs.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
> Just one question about the actual implementation of the patch - why are
> you setting the OS version *before* you call GetVersionEx()?
The Microsoft Example did a memset on the structure before calling void GetVersionEx().
Setting it to a version that needs the Global\ is only a safeguard against a failing
call. I guess the call cannot fail, and thus setting it before is not really needed.
> It'll just get overwritten...
Yes, if the void call does not fail to work.
Andreas
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2004-11-02 13:30:03 | Re: [PATCHES] Open Items |
| Previous Message | Tatsuo Ishii | 2004-11-02 12:53:54 | Re: charset/collation in values |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2004-11-02 13:30:03 | Re: [PATCHES] Open Items |
| Previous Message | Magnus Hagander | 2004-11-02 12:38:26 | Re: [PATCHES] Open Items |