Re: minor compiler warning on OpenBSD

From: Stefan Kaltenbrunner <stefan(at)kaltenbrunner(dot)cc>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: minor compiler warning on OpenBSD
Date: 2007-07-12 07:06:53
Message-ID: 4695D30D.2050203@kaltenbrunner.cc
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
>> My local manpage for strftime says that we can get around this warning
>> by overloading it with something like
>
>> size_t
>> my_strftime(char *s, size_t max, const char *fmt,
>> const struct tm *tm)
>> {
>> return strftime(s, max, fmt, tm);
>> }
>
> Hey, that works nicely. On my version of gcc, it suppresses the warning
> even if my_strftime is marked "static inline", which should mean that
> there's no runtime penalty.
>
> I've committed the patch to HEAD --- Stefan, would you check if it
> silences your version of gcc?

yeah that patch fixes the warning for me too - thanks!

Stefan

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2007-07-12 07:53:16 Re: [GENERAL] Count(*) throws error
Previous Message alexander lunyov 2007-07-12 06:54:58 Re: russian case-insensitive regexp search not working