Re: updated WIP: arrays of composites

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Gregory Stark <stark(at)enterprisedb(dot)com>, David Fetter <david(at)fetter(dot)org>, "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: updated WIP: arrays of composites
Date: 2007-05-11 23:38:20
Message-ID: 4644FE6C.80500@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>
>> Tom Lane wrote:
>>
>>> Auto-rename. I'm working on a patch now, and it doesn't look like it'll
>>> be too awful. Will post it for comments when it's working.
>>>
>
>
>> Ok, cool. I look forward to it.
>>
>
> Here's a bare-bones patch (no doc or regression tests). Seems to work.
> Anyone think this is too ugly a way to proceed?
>
>
>

Summarising the behaviour as I understand it:

. if you never name a type/table with a name beginning with underscore,
behaviour is as expected - type foo gets array type _foo
. if you create a type foo and then create a type _foo, the array type
for foo will first be renamed to __foo, and the new array type for _foo
will be ___foo
. if you create type _foo and then create type foo, the corresponding
array types will be __foo and ___foo as per my patch, with no renaming
required.

I think I like it. Certainly seems to get round the ordering problem nicely.

cheers

andrew

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2007-05-11 23:40:44 Re: [GENERAL] dropping role w/dependent objects
Previous Message Tom Lane 2007-05-11 23:20:45 Re: updated WIP: arrays of composites