Re: New idea for patch tracking

From: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: New idea for patch tracking
Date: 2007-05-05 14:24:38
Message-ID: 463C93A6.4040401@sun.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-www

I would like to add one point:

Bruce Momjian wrote:

>
> Patch committers check several things before applying a patch:
>
> 1) Follows the SQL standard or community agreed-upon behavior
> 2) Style merges seamlessly into the surrounding code
> 3) Written as simply and efficiently as possible
> 4) Uses the available PostgreSQL subsystems properly
> 5) Contains sufficient comments
> 6) Contains code that works on all supported operating systems
> 7) Has proper documentation
> 8) Passes all regression tests

8.5) Contains regression test(s) which covered performed changes

> 9) Behaves as expected, even under unusual cirumstances
> 10) Contains no reliability risks
> 11) Does not overly complicate the source code
> 12) If performance-related, it should have a measureable performance benefit
> 13) Is of sufficient usefulness to the average PostgreSQL user
> 14) Follows existing PostgreSQL coding standards
>

Zdenek

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2007-05-05 14:33:23 Re: New idea for patch tracking
Previous Message Peter Eisentraut 2007-05-05 13:58:54 Re: conversion_procs makefiles

Browse pgsql-www by date

  From Date Subject
Next Message Bruce Momjian 2007-05-05 14:33:23 Re: New idea for patch tracking
Previous Message Robert Haas 2007-05-05 11:57:36 Re: Feature freeze progress report