From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
Cc: | pgsql-hackers(at)postgresql(dot)org, Chris Campbell <chris(at)bignerdranch(dot)com> |
Subject: | Re: libreadline only used with psql? |
Date: | 2006-10-07 20:34:10 |
Message-ID: | 4625.1160253250@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> Chris Campbell wrote:
>> If that's the case, how hard would it be to link only psql with
>> readline (or libedit)?
> This is already addressed, more or less, in 8.2.
We've suppressed libreadline in the backend, but not in any of the other
client programs (eg, pg_dump still has it). Not sure whether Chris
really cares about those. In any case, I think it's inappropriate
for configure to know exactly which programs need which libraries.
It'd probably be more maintainable in the long run to propagate
src/backend/Makefile's technique into the other Makefiles:
# The backend doesn't need everything that's in LIBS, however
LIBS := $(filter-out -lz -lreadline -ledit -ltermcap -lncurses -lcurses, $(LIBS))
with suitable adjustment of the filter list for each program.
(But possibly "-lreadline -ledit -ltermcap -lncurses -lcurses"
should be factored out as a READLINE_LIBS variable or some such.)
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2006-10-07 21:10:42 | Re: pg_dump exclusion switches and functions/types |
Previous Message | Tom Lane | 2006-10-07 20:23:53 | Re: Checking max_stack_depth automatically |