Re: As proposed the complete changes to pg_trigger and pg_rewrite

From: Jan Wieck <JanWieck(at)Yahoo(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: As proposed the complete changes to pg_trigger and pg_rewrite
Date: 2007-03-16 04:12:32
Message-ID: 45FA1930.70509@Yahoo.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

On 3/15/2007 11:16 PM, Tom Lane wrote:
> Jan Wieck <JanWieck(at)Yahoo(dot)com> writes:
>> Attached is the completed patch that changes pg_trigger and extends
>> pg_rewrite in order to allow triggers and rules to be defined with
>> different, per session controllable, behaviors for replication purposes.
>
> The SPI_savedplans part of this is pretty bletcherous, and has been
> overtaken by events anyway. I'd suggest testing whether plancache.c
> has anything in its list.

Hehe,

after today's commit by you it also throws a cvs merge conflict exactly
there ...

After a quick look it seems that another little function in there,
checking if (cached_plans_list == NIL), would do exactly that.

Easy enough to adjust to that.

Jan

--
#======================================================================#
# It's easier to get forgiveness for being wrong than for being right. #
# Let's break this rule - forgive me. #
#================================================== JanWieck(at)Yahoo(dot)com #

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Joshua D. Drake 2007-03-16 04:32:44 Re: tsearch_core for inclusion
Previous Message Tom Lane 2007-03-16 04:11:45 Re: tsearch_core for inclusion

Browse pgsql-patches by date

  From Date Subject
Next Message Magnus Hagander 2007-03-16 06:07:36 Re: Additional global stats
Previous Message Tom Lane 2007-03-16 03:16:10 Re: As proposed the complete changes to pg_trigger and pg_rewrite