Re: pgstat: remove delayed destroy / pipe: socket

From: "Peter Brant" <Peter(dot)Brant(at)wicourts(dot)gov>
To: <pgsql-patches(at)postgresql(dot)org>, "Magnus Hagander" <mha(at)sollentuna(dot)net>
Subject: Re: pgstat: remove delayed destroy / pipe: socket
Date: 2006-04-06 17:58:46
Message-ID: 44351086020000BE000029CB@gwmta.wicourts.gov
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

>>> "Magnus Hagander" <mha(at)sollentuna(dot)net> 04/06/06 7:26 pm >>>

> BTW, what's with the change to all the error msgs?
Ah, I'd assumed the %ui was a typo in the format string. If the intent
was to print e.g. 10022i, I'll change it back.

> And finally, the error handling looks a bit off? We specifically
*don't*
> want it to log an error for the WSAECONNRESET state - it's a normal
> state. Or am I reading the patch wrong?
If error is WSAECONNRESET, the return value is reset to zero. That
will prevent an error message from being displayed (unless I'm reading
something wrong).

> Do you get anything at all in the logs when this happens? Are you
sure
> the reason is that it picks up an empty file, or could it be
something
> else?
There is nothing in the logs. It could definitely be something else.
A rename race condition was just our best theory.

Pete

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Magnus Hagander 2006-04-06 18:14:49 Re: pgstat: remove delayed destroy / pipe: socketerror fix
Previous Message Kevin Grittner 2006-04-06 17:46:23 Re: pgstat: remove delayed destroy / pipe: socket