Re: pg_xlogdump --stats

On 04 July 2014 12:07, Abhijit Menon-Sen Wrote,

> -----Original Message-----
> From: Abhijit Menon-Sen [mailto:ams(at)2ndQuadrant(dot)com]
> Sent: 04 July 2014 12:07
> To: Dilip kumar
> Cc: pgsql-hackers(at)postgresql(dot)org; furuyao(at)pm(dot)nttdata(dot)co(dot)jp
> Subject: Re: [HACKERS] pg_xlogdump --stats
>
> At 2014-06-30 05:19:10 +0000, dilip(dot)kumar(at)huawei(dot)com wrote:
> >
> > Please fix these issues and send the updated patch..
> >
> > I will continue reviewing the patch..
>
> Did you get anywhere with the updated patch?
>

Patch looks fine to me, except few small comments.

1. Update this new option in "usage" function also this still have the old way { -z, --stats[=record] }

{"stats", no_argument, NULL, 'z'},
{"record-stats", no_argument, NULL, 'Z'},

2. While applying stats-newopt.dif (after applying stat2.diff), some error in merging sgml file.

patching file `doc/src/sgml/pg_xlogdump.sgml'
Hunk #1 FAILED at 181.
1 out of 1 hunk FAILED -- saving rejects to doc/src/sgml/pg_xlogdump.sgml.rej

Once you fix above erros, I think patch is ok from my side.

Thanks & Regards,
Dilip Kumar