From: | Dilip kumar <dilip(dot)kumar(at)huawei(dot)com> |
---|---|
To: | Sawada Masahiko <sawada(dot)mshk(at)gmail(dot)com> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Logging WAL when updating hintbit |
Date: | 2013-12-13 08:49:18 |
Message-ID: | 4205E661176A124FAF891E0A6BA9135265934CA3@SZXEML507-MBS.china.huawei.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Dec 13, 2013 at 11:25, Sawada Masahiko Wrote
> >> I attached the patch which have modified based on Robert suggestion,
> >> and fixed typo.
> >
> > I have reviewed the modified patch and I have some comments..
> >
> > 1. Patch need to be rebased (failed applying on head)
> >
> > 2. crc field should be at end in ControlFileData struct, because for
> crc calculation, it directly take the offset of crc field in
> ControlFileData.
> >
> > /* CRC of all above ... MUST BE LAST! */
> > pg_crc32 crc;
> > +
> > + /* Enable logging WAL when updating hint bits */
> > + bool wal_log_hintbits;
> > } ControlFileData;
> >
> > 3. wal_log_hintbits field should be printed in PrintControlValues
> function.
> >
>
> Thank you for reviewing the patch!
> I have modified the patch base on your comment, and I attached the v7
> patch.
Thanks, patch Looks fine to me, Marked as Ready for Committer.
Regards,
Dilip
From | Date | Subject | |
---|---|---|---|
Next Message | Sawada Masahiko | 2013-12-13 08:56:20 | Re: Logging WAL when updating hintbit |
Previous Message | Etsuro Fujita | 2013-12-13 08:40:50 | Re: Show lossy heap block info in EXPLAIN ANALYZE for bitmap heap scan |