Re: thread safety tests

From: Jan Wieck <JanWieck(at)Yahoo(dot)com>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: thread safety tests
Date: 2004-06-09 15:05:23
Message-ID: 40C72733.6080003@Yahoo.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 6/9/2004 9:36 AM, Bruce Momjian wrote:
>
>> Also, I would suggest that we allow to build the libpq with thread
>> specific compiler options, even if it is not entirely thread safe. It
>> would require that a really multithreaded application has to have
>> mutexes around certain operations, but being entirely unable to
>> configure in a way that adds thread compile options to the CFLAGS makes
>> libpq completely useless for multithreaded programs on some platforms
>> (for example Solaris).
>
> I am confused what you are suggesting. Are you saying to use thread
> flags but not the other things that make is thread-safe? There isn't
> much else other than the flags actually. Now that more OS's are
> thread-safe by default, we could consider using threading if it is
> available by default. We would need some way of reporting that to the
> user, perhaps via an installed readme file or a pg_config output option.

The problem is that if your thread-safety tests fail, there is no way to
build libpq with -pthread and -DREENTRANT or whatever is required on
that platform. On Solaris this results in errno being defined as

extern int errno;

as supposed to

#define errno *(errno())

which makes libpq on Solaris completely useless for every program that
uses threads for "something". There is still value in compiling it with
thread support compiler flags, even if it will not result in a thread
safe libpq.

Jan

--
#======================================================================#
# It's easier to get forgiveness for being wrong than for being right. #
# Let's break this rule - forgive me. #
#================================================== JanWieck(at)Yahoo(dot)com #

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2004-06-09 15:16:02 Re: thread safety tests
Previous Message Andrew Dunstan 2004-06-09 15:05:20 Re: Improving postgresql.conf