Re: ADD/DROPS INHERIT (actually INHERIT / NO INHERIT)

From: "Andrew Dunstan" <andrew(at)dunslane(dot)net>
To: <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: <pgsql-patches(at)jdrake(dot)com>, <bruce(at)momjian(dot)us>, <gsstark(at)mit(dot)edu>, <pgsql-patches(at)postgresql(dot)org>, <simon(at)2ndquadrant(dot)com>
Subject: Re: ADD/DROPS INHERIT (actually INHERIT / NO INHERIT)
Date: 2006-07-03 09:59:01
Message-ID: 4053.24.211.165.134.1151920741.squirrel@www.dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane said:
> Jeremy Drake <pgsql-patches(at)jdrake(dot)com> writes:
>> On Sun, 2 Jul 2006, Tom Lane wrote:
>>> Nah, it was a false alarm: I was looking at the first post-patch
>>> report,
>>>
http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=mongoose&dt=2006-07-02%2003:30:01>>> but apparently mongoose had managed to pick up a partially-updated
>>> snapshot. The later reports (including mongoose's own next try an
>>> hour later) were all OK.
>
>> As the keeper of mongoose, is there anything I should do to prevent it
>> from picking up a partially-updated snapshot? Or is this just a race
>> condition that's bound to happen now and then?
>
> Well, it's certainly not *your* problem to fix. I suspect that this
> risk is inherent in CVS --- although there might also be something
> involved about our primary-vs-mirror CVS setup. Does anyone know
> exactly how the mirroring is done and whether it makes any attempt to
> ensure a consistent copy?
>

Since CVS updates are not atomic, it's hard to see how mirroring could be,
unless you did something like disallow updates, mirror, allow updates. I
suspect such a cure would be worse than the disease. This is such a rare
event that I don't think it's worth the trouble. Buildfarm members are doing
200 builds a day or more, and I can't recall having seen this before.

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message ITAGAKI Takahiro 2006-07-03 10:11:34 Auto selection of internal representation for integer NUMERIC
Previous Message Tom Lane 2006-07-03 04:55:18 Re: different sort order in windows and linux version

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2006-07-03 14:48:04 Re: ADD/DROPS INHERIT (actually INHERIT / NO INHERIT)
Previous Message Tom Lane 2006-07-03 03:43:47 Re: ADD/DROPS INHERIT (actually INHERIT / NO INHERIT)