| From: | "Andrew Dunstan" <andrew(at)dunslane(dot)net> |
|---|---|
| To: | <pgman(at)candle(dot)pha(dot)pa(dot)us> |
| Cc: | <andrew(at)dunslane(dot)net>, <rurban(at)x-ray(dot)at>, <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: APR 1.0 released |
| Date: | 2004-09-09 03:19:21 |
| Message-ID: | 4052.24.211.141.25.1094699961.squirrel@www.dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Bruce Momjian said:
> Andrew Dunstan wrote:
>>
>>
>> Reini Urban wrote:
>>
>> >
>> >
>> > FYI: WIN32 is also defined because <windows.h> is included.
>> > (/usr/incluse/w32api/windef.h)
>> > If you want this or that, do proper nesting, and use #else.
>> >
>> >
>>
>> Ugh, yes. A little experimentation shows that __WIN32__ is defined for
>> MinGW only, but WIN32 is for both. I wonder how we missed that in
>> various places. Maybe we need a little audit of the use of WIN32.
>
> Done, and patch attached and applied. Hopefully at least Cygwin will
> compile dirmod.c now. (Most of the patch is consistency
> reorganization.) We still need a review of that file.
>
I don't understand most of this patch. What difference does changing the
preprocessor test order make?
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephan Szabo | 2004-09-09 03:57:30 | Re: Making AFTER triggers act properly in PL functions |
| Previous Message | Tom Lane | 2004-09-09 01:03:40 | TRIGGER_DEFERRED_HAS_BEFORE ? |