Re: Streaming Replication patch for CommitFest 2009-09

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Streaming Replication patch for CommitFest 2009-09
Date: 2009-10-07 01:36:33
Message-ID: 3f0b79eb0910061836u7174e9b9p5a727c7572253590@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Tue, Oct 6, 2009 at 10:42 PM, Alvaro Herrera
<alvherre(at)commandprompt(dot)com> wrote:
> Hmm.  Without looking at the patch at all, this seems similar to how
> autovacuum does things: autovac launcher signals postmaster that a
> worker needs to be started.  Postmaster proceeds to fork a worker.  This
> could obviously fail for a lot of reasons.

Yeah, I drew upon the autovac code.

> Now, there is code in place to notify the user when forking fails, and
> this is seen on the wild quite a bit more than one would like :-(  I
> think it would be a good idea to have a retry mechanism in the
> walreceiver startup mechanism so that recovery does not get stuck due to
> transient problems.

Agreed. The latest patch provides the retry mechanism.

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message KaiGai Kohei 2009-10-07 01:45:48 Re: [PATCH] DefaultACLs
Previous Message KaiGai Kohei 2009-10-07 01:11:32 Re: [PATCH] Largeobject access controls