Re: Backpatch FK changes to 7.3 and 7.2?

From: Jan Wieck <JanWieck(at)Yahoo(dot)com>
To: Stephan Szabo <sszabo(at)megazone23(dot)bigpanda(dot)com>
Cc: Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp>, chriskl(at)familyhealth(dot)com(dot)au, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Backpatch FK changes to 7.3 and 7.2?
Date: 2003-04-08 10:24:55
Message-ID: 3E92A377.F2F63C2C@Yahoo.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

Stephan Szabo wrote:
>
> On Tue, 8 Apr 2003, Tatsuo Ishii wrote:
>
> > > > The changes I committed to address most of the FK deadlock problems
> > > > reported can easily be applied to the 7.3 and 7.2 source trees as well.
> > > >
> > > > Except for a slight change in the text of the error message that gets
> > > > thrown "if one tries to delete a referenced PK for which a FK with ON
> > > > DELETE SET DEFAULT exists" (it's a rare case, believe me), this patch
> > > > would qualify for backpatching. The unnecessary FOR UPDATE lock of
> > > > referenced rows could be counted as a bug.
> > > >
> > > > Opinions?
> > >
> > > Since I seem to suffer from these horrible deadlock problems all the
> > > time, I'd like it to be backported to 7.3...
> >
> > Me too!
>
> As a note, this'll solve some of the deadlocks on fk update (generally the
> key values aren't touched) but not insert related ones (two rows inserted
> to the same primary key causing one to wait and possible deadlocks)
>
> In any case, why don't we get a patch against 7.3, and make an
> announcement and let people who are interested use it and test it. With
> in-field testing it'd probably be safe enough. :)

Here it is.

Jan

--
#======================================================================#
# It's easier to get forgiveness for being wrong than for being right. #
# Let's break this rule - forgive me. #
#================================================== JanWieck(at)Yahoo(dot)com #

Attachment Content-Type Size
ri_triggers.c.diff.732 text/plain 2.2 KB

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Tony Harper 2003-04-08 10:44:42 Re: RelationBuildDesc Notice (corrupt DB?)
Previous Message Laurent Perez 2003-04-08 09:11:03 CVS doesn't compile initdb and other binaries

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2003-04-08 12:21:30 Re: HP-UX 11.22 (IA64) IPF Patch for PostgreSQL 7.3.2
Previous Message Nigel J. Andrews 2003-04-08 09:04:30 Casting