Re: WIP: psql default banner patch

From: "Brendan Jurd" <direvus(at)gmail(dot)com>
To: "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>
Cc: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: WIP: psql default banner patch
Date: 2008-04-23 00:25:19
Message-ID: 37ed240d0804221725u672a641cx2851f5f8f475800a@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Wed, Apr 23, 2008 at 10:11 AM, Joshua D. Drake wrote:
> On Wed, 23 Apr 2008 10:07:46 +1000
> "Brendan Jurd" wrote:
> > In such an environment, it's *very* useful to have instant feedback on
> > which server I've just connected to with psql.
>
> The patch as it sits would provide you with that. The only time it
> doesn't give you that info is if the version matches.
>

That's just it, I would want the banner to tell me the server and
client version in the same way, every time. This information doesn't
stop being interesting when the versions happen to match.

With your proposal, when the banner goes silent about the version, I
need to think "Oh yeah, that means that the server version is the same
as the psql version. Umm, what version of psql did I execute again?"
Bearing in mind that I might be executing any one of several psqls I
might have installed at any given time, and that the versions I have
installed will differ, depending on which machine I happen to be on.

Cheers,
BJ
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: http://getfiregpg.org

iD8DBQFIDoHt5YBsbHkuyV0RAjVJAJ0XU8QBzfgomy29gxNtAjltNB+7QQCgofUG
4dJJFnrrX9yYKwDwNbD+sy4=
=w+7D
-----END PGP SIGNATURE-----

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Joshua D. Drake 2008-04-23 00:37:15 Re: WIP: psql default banner patch
Previous Message Joshua D. Drake 2008-04-23 00:12:05 Re: WIP: psql default banner patch