| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Joseph Adams <joeyadams3(dot)14159(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: patch: utf8_to_unicode (trivial) |
| Date: | 2010-08-13 18:21:58 |
| Message-ID: | 3781.1281723718@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Fri, Aug 13, 2010 at 1:50 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> AFAICS the version in mbprint.c is flat out wrong, and the only reason
>> nobody's noticed is that it should never get passed a more-than-4-byte
>> sequence anyway.
> Should we fix it, then, and if so how far should we go back?
Yes, I'd vote for back-patching, at least to all versions in which the
wchar.c version looks like that.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Boszormenyi Zoltan | 2010-08-13 18:31:17 | WIP partial replication patch |
| Previous Message | Robert Haas | 2010-08-13 18:11:27 | Re: patch: utf8_to_unicode (trivial) |