Re: pg_test_fsync problem

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>, Vladimir Kokovic <vladimir(dot)kokovic(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, Bruce Momjian <bruce(at)momjian(dot)us>
Subject: Re: pg_test_fsync problem
Date: 2011-01-23 02:17:28
Message-ID: 373.1295749048@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I wrote:
> He's complaining that it dies with EINVAL.

> I notice that (1) it's using O_DIRECT even though the printout claims
> otherwise, and (2) it's writing from a buffer that has no better than
> char alignment, which is certainly not OK for O_DIRECT. Either one
> of those could plausibly result in EINVAL ...

Oh, scratch that: the buffer is properly aligned, it's the length that's
bogus for O_DIRECT. I rather imagine that test_open_sync is meant to be
writing so many kilobytes, not so many bytes.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2011-01-23 02:19:14 Re: sepgsql contrib module
Previous Message Andrew Dunstan 2011-01-23 02:14:38 Re: Perl 5.12 complains about ecpg parser-hacking scripts