| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | "Magnus Hagander" <mha(at)sollentuna(dot)net> |
| Cc: | pgsql-patches(at)postgreSQL(dot)org, "Palle Girgensohn" <girgen(at)pingpong(dot)net> |
| Subject: | Re: Win32 unicode vs ICU |
| Date: | 2005-08-23 17:16:10 |
| Message-ID: | 3649.1124817370@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
I looked over the proposed patch a bit and found some problems --- in
particular, if I read M$'s documentation about MultiByteToWideChar
correctly, they chose an API that fails for zero-length input, and
so you gotta program around that. Also, varstr_cmp() cannot assume
it gets null-terminated input.
I cannot test the attached revised patch; please check it out.
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| unknown_filename | text/plain | 5.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joshua D. Drake | 2005-08-23 17:25:59 | Re: Inconsistencies with create role |
| Previous Message | Tom Lane | 2005-08-23 16:03:44 | Re: Win32 unicode vs ICU |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2005-08-23 21:01:45 | Re: Win32 Thread Safety |
| Previous Message | Tom Lane | 2005-08-23 16:03:44 | Re: Win32 unicode vs ICU |