| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Teodor Sigaev <teodor(at)sigaev(dot)ru> |
| Cc: | Jeff Davis <pgsql(at)j-davis(dot)com>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Review: B-Tree emulation for GIN |
| Date: | 2009-03-25 16:55:10 |
| Message-ID: | 3638.1238000110@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
BTW ... while I'm thinking about it: it seems to me to be a serious
error that the consistent() function isn't given nkeys so that it can
know the length of the arrays it's being handed. I suppose it's
possible for it to re-deduce nkeys by examining the query datum, but
that could be quite expensive; and it's certainly error-prone to have
to keep extractQuery() and consistent() in sync on this. Since we are
adding arguments to consistent() anyway for 8.4, I propose that its
signature ought to be
bool consistent(bool check[], StrategyNumber n, Datum query,
int32 nkeys, bool *recheck, Pointer extra_data[])
where the first three arguments are what existed in 8.3.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2009-03-25 16:59:03 | Re: cached plan issue in trigger func |
| Previous Message | Mark Cave-Ayland | 2009-03-25 16:49:56 | Re: Proper entry of polygon type data |