From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, Euler Taveira <euler(at)timbira(dot)com(dot)br>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: psql \d+ and oid display |
Date: | 2014-03-29 11:18:51 |
Message-ID: | 359B1FA8-1D68-44DA-8D49-1C205C829AC4@gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mar 28, 2014, at 2:41 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
>> On Thu, Mar 27, 2014 at 02:54:26PM -0400, Stephen Frost wrote:
>>> I believe Bruce was suggesting to show it when it is set to *not* the
>>> default, which strikes me as perfectly reasonable.
>
>> We seem to be split on the idea of having "Has OIDs" display only when
>> the oid status of the table does not match the default_with_oids
>> default.
>
> FWIW, I think that having the display depend on what that GUC is set to
> is a seriously *bad* idea. It will mean that you don't actually know,
> when looking at the output of \d, whether the table has OIDs or not.
Agreed.
> I could get behind a proposal to suppress the line when there are not
> OIDs, full stop; that is, we print either "Has OIDs: yes" or nothing.
> But I think this patch just makes things even more surprising when
> default_with_oids is turned on.
I see little reason to tinker with the status quo.
...Robert
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2014-03-29 13:32:06 | Re: pgsql: Revert "Secure Unix-domain sockets of "make check" temporary clu |
Previous Message | Christoph Berg | 2014-03-29 09:04:55 | Re: Securing "make check" (CVE-2014-0067) |