| From: | Alex Hunsaker <badalex(at)gmail(dot)com> |
|---|---|
| To: | "David E(dot) Wheeler" <david(at)kineticode(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Ignoring white space in regression tests really a good idea? |
| Date: | 2009-11-22 00:05:10 |
| Message-ID: | 34d269d40911211605p7deaad1ax474e4529bfea6e6d@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Nov 21, 2009 at 16:07, David E. Wheeler <david(at)kineticode(dot)com> wrote:
> On Nov 22, 2009, at 7:49 AM, Tom Lane wrote:
>
>> I'm thinking maybe we should remove -w. Comments?
>
> Have you tried it on the existing tests to see what happens?
For me there I get:
*the breaking in create_cast
*various things in foreign_key due to the tests not having spaces
after commas i.e:
! DETAIL: Key (ftest1,ftest2)=(2,2) is not present in table "pktable".
! DETAIL: Key (ftest1, ftest2)=(100, 2) is not present in table "pktable".
* exta space after a "
! CONTEXT: SQL statement "SELECT 1/ $1 "
! CONTEXT: SQL statement "SELECT 1/$1"
All those things are easily fixable so it seems worth it to me +1
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2009-11-22 05:23:39 | Re: Unicode UTF-8 table formatting for psql text output |
| Previous Message | Jan Urbański | 2009-11-22 00:00:05 | Re: Partitioning option for COPY |