| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | Greg Stark <stark(at)mit(dot)edu>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Sergey Muraviov <sergey(dot)k(dot)muraviov(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Emre Hasegeli <emre(at)hasegeli(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: wrapping in extended mode doesn't work well with default pager |
| Date: | 2014-06-12 02:16:53 |
| Message-ID: | 3376.1402539413@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Noah Misch <noah(at)leadboat(dot)com> writes:
> Based on the commit message and procedural history, I thought commit 6513633
> was changing behavior solely for the combination of "\pset expanded" and
> "\pset format wrapped". Peter's and my test cases show that it also changed
> behavior for "\pset expanded" alone. That's a bug, unless someone sees to
> argue that the new "\pset expanded" behavior is a desirable improvement in
> spite of its origin as an accident. Altering an entrenched psql output format
> is a big deal.
TBH I'm wondering if we shouldn't just revert that patch (and the
subsequent fix attempts). It was not a major feature and I'm thinking
we have better things to do right now than try to fix the multiple
logic holes it evidently has. The author's certainly welcome to try
again with a more carefully thought-through patch for 9.5.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2014-06-12 02:37:36 | Re: API change advice: Passing plan invalidation info from the rewriter into the planner? |
| Previous Message | Noah Misch | 2014-06-12 01:34:02 | Re: wrapping in extended mode doesn't work well with default pager |