Re: pgsql: Keep pg_stat_statements' query texts in a file, not in shared me

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Geoghegan <pg(at)heroku(dot)com>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, KONDO Mitsumasa <kondo(dot)mitsumasa(at)lab(dot)ntt(dot)co(dot)jp>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Keep pg_stat_statements' query texts in a file, not in shared me
Date: 2014-01-28 02:08:00
Message-ID: 32681.1390874880@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Peter Geoghegan <pg(at)heroku(dot)com> writes:
> On Mon, Jan 27, 2014 at 5:34 PM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>> The query texts are particularly uninteresting since I assume the data
>> values in the query have already been mostly dissolved away by
>> pg_stat_statements.

> Actually, it is possible for the query string to still have constants
> if things are timed just right. I do see it in the wild, albeit very
> infrequently.

"Timed just right"? I could see it possibly happening due to queryid
collisions, but I'm not seeing how it would happen absent such a hash
collision.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message KONDO Mitsumasa 2014-01-28 02:17:21 Re: pgsql: Keep pg_stat_statements' query texts in a file, not in shared me
Previous Message Peter Geoghegan 2014-01-28 02:07:18 Re: pgsql: Keep pg_stat_statements' query texts in a file, not in shared me

Browse pgsql-hackers by date

  From Date Subject
Next Message KONDO Mitsumasa 2014-01-28 02:17:21 Re: pgsql: Keep pg_stat_statements' query texts in a file, not in shared me
Previous Message Peter Geoghegan 2014-01-28 02:07:18 Re: pgsql: Keep pg_stat_statements' query texts in a file, not in shared me