| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Sawada Masahiko <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: The number of character limitation of custom script on pgbench |
| Date: | 2013-11-16 00:48:06 |
| Message-ID: | 32435.1384562886@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Sawada Masahiko <sawada(dot)mshk(at)gmail(dot)com> writes:
> I attached the patch which solves this problem, and have submitted to CF3.
> I changed how to get the SQL from custom script file.
This needed a bit of work:
- Use of strncat didn't seem particularly safe, or efficient. I changed
it to explicitly account for space consumption in the result buffer.
- It leaked the buffer space used. While this likely doesn't matter for
foreseeable usage, it seemed worth fixing.
- Didn't do the right thing for a file not ending with a newline.
- Didn't follow project code layout standards.
I've committed the attached revised version.
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| pgbench-line-length-fix-2.patch | text/x-diff | 2.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nigel Heron | 2013-11-16 01:37:23 | Re: review: autovacuum_work_mem |
| Previous Message | Andrew Dunstan | 2013-11-16 00:44:08 | Re: additional json functionality |