Re: Patch to fix a couple of compiler warnings from 80a5cf64

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patch to fix a couple of compiler warnings from 80a5cf64
Date: 2014-04-13 15:01:35
Message-ID: 31597.1397401295@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> The attached patch fixes a couple of compiler warnings seen by the MSVC
> build.

Committed, thanks.

> I'm not quite sure why I get 2 warnings rather than 8, but the attached
> seems to make them go away, for what it's worth.

I think it's complaining about the 2 cases where rounding off to float4
would actually change the value compared to float8. The other 6 numbers
are exactly represented anyway.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2014-04-13 15:31:41 Re: Window function optimisation, allow pushdowns of items matching PARTITION BY clauses
Previous Message Thomas Mayer 2014-04-13 14:50:24 Re: Window function optimisation, allow pushdowns of items matching PARTITION BY clauses