Re: Sampling profiler updated

From: Jaime Casanova <jcasanov(at)systemguards(dot)com(dot)ec>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Dimitri Fontaine <dfontaine(at)hi-media(dot)com>, Itagaki Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Sampling profiler updated
Date: 2009-07-18 21:36:24
Message-ID: 3073cc9b0907181436g325de17cu4dff0fbed27a3cea@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Jul 18, 2009 at 3:38 PM, Robert Haas<robertmhaas(at)gmail(dot)com> wrote:
> On Sat, Jul 18, 2009 at 4:09 PM, Dimitri Fontaine<dfontaine(at)hi-media(dot)com> wrote:
>> So I'm going to change patch state to "Returned with Feedback" as I guess
>> we'll need to talk about the issue and find a way to solve it, and I don't
>> think this state prevent from getting back to the patch in this same fest.
>
> In general I would prefer patches to be set to Returned with Feedback
> only when we think they are probably done for this CommitFest.

why? it seems very simple as is:
Returned with Feedback means there is something to clean, when the
author fixes the problem he can update it to Needs review.

> Otherwise, it's hard to tell which are really done and which are maybe
> done.
>

when the rrr thinks the patch is in good shape mark it as Ready for
committer then the commiter could apply, reject or return with
feedback again...

at the end of the commitfest if there are patches on returned with
feedback and the author respond those will go to the next
commitfest...

--
Atentamente,
Jaime Casanova
Soporte y capacitación de PostgreSQL
Asesoría y desarrollo de sistemas
Guayaquil - Ecuador
Cel. +59387171157

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Davis 2009-07-18 21:48:26 Re: WIP: Deferrable unique constraints
Previous Message Tom Lane 2009-07-18 21:28:34 Re: Sampling profiler updated