Re: [GENERAL] Performance of full outer join in 8.3

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>, Christian Schröder <cs(at)deriva(dot)de>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [GENERAL] Performance of full outer join in 8.3
Date: 2009-04-15 23:39:51
Message-ID: 3010.1239838791@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> We could add some regression tests that create a sample data set,
> ANALYZE it, and then EXPLAIN various things. The results should be
> deterministic,

Sorry, you're wrong.

The output of EXPLAIN is nowhere near stable enough to use within the
current exact-match regression test framework. I'm not sure it would
be stable even if we suppressed the rowcount and cost figures. Those
figures vary across platforms (because of alignment effects and probably
other things) and are also sensitive to the timing of autovacuums. It
is known that a nontrivial fraction of the existing regression test
cases do suffer from uninteresting plan changes across platforms or
as a result of various phase-of-the-moon effects; that's why we keep
having to add "ORDER BY" clauses now and then.

The other problem with any large set of such tests is that any time you
intentionally change the optimizer, a great deal of careful analysis
would be needed to determine if the resulting EXPLAIN changes were good,
bad, or indifferent; not to mention whether the change *should* have
changed some plans that did not change.

There might be net value in maintaining such a test suite, but it would
be a lot of work with no certain benefit, and I don't see anyone
stepping up to do it.

regards, tom lane

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Robert Haas 2009-04-16 00:58:18 Re: [GENERAL] Performance of full outer join in 8.3
Previous Message Robert Haas 2009-04-15 23:23:01 Re: [GENERAL] Performance of full outer join in 8.3

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2009-04-15 23:43:56 Re: libpq is not thread safe
Previous Message Robert Haas 2009-04-15 23:23:01 Re: [GENERAL] Performance of full outer join in 8.3