| From: | Florian Pflug <fgp(at)phlo(dot)org> |
|---|---|
| To: | Peter Geoghegan <peter(at)2ndquadrant(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>, Robert Haas <robertmhaas(at)gmail(dot)com>, Greg Stark <stark(at)mit(dot)edu>, PG Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: sortsupport for text |
| Date: | 2012-06-21 09:24:22 |
| Message-ID: | 2CF4AD23-269D-45CA-B850-4E6ED3090537@phlo.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Jun21, 2012, at 02:22 , Peter Geoghegan wrote:
> I've written a very small C++ program, which I've attached, that
> basically proves that this can still make a fairly large difference -
> I hope it's okay that that it's C++, but that allowed me to write the
> program quickly, with no dependencies for anyone who cares to try this
> out, other than a C++ compiler and the standard library.
Uh, are you sure the results aren't swapped? string_wrapper takes a
parameter called use_strcoll, and it indeed uses strcoll() if that
parameter is true, and strxfm() otherwise. But then it passes *false*
to determine the speed of strcoll(), and *true* to determine the speed
of strxfm()...
Also, place_random_string() needs to insert a terminating zero byte,
otherwise set_test segfaults, at least on my OSX machine.
best regards,
Florian Pflug
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2012-06-21 09:55:53 | Re: sortsupport for text |
| Previous Message | Amit Kapila | 2012-06-21 08:58:25 | Re: Allow WAL information to recover corrupted pg_controldata |