Re: patch: Add columns via CREATE OR REPLACE VIEW

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Robert Haas" <robertmhaas(at)gmail(dot)com>
Cc: "Gregory Stark" <stark(at)enterprisedb(dot)com>, "Alvaro Herrera" <alvherre(at)commandprompt(dot)com>, "PostgreSQL-development Hackers" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: patch: Add columns via CREATE OR REPLACE VIEW
Date: 2008-08-07 23:56:18
Message-ID: 29680.1218153378@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"Robert Haas" <robertmhaas(at)gmail(dot)com> writes:
> On Thu, Aug 7, 2008 at 5:26 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Because it sidesteps the problem of tracking which column is supposed to
>> be which. If you try to do it through CREATE OR REPLACE VIEW, you have
>> to either be extremely restrictive (like probably not allow renaming
>> of columns at all), or write some AI-complete algorithm to guess at what
>> the user intended.

> The current code takes the approach of being extremely restrictive -
> it doesn't let you change anything at all. The code I'm proposing
> manages to relax that restriction without creating any ambiguity that
> anyone has been able to point out. All of the ambiguities that have
> been mentioned are problems that might be created by some other,
> entirely hypothetical patch.

Well, my feeling is that if we are inventing a new feature we ought not
paint ourselves into a corner by failing to consider what will happen
when obvious extensions to the feature are attempted. Whether the
present patch is self-consistent is not the question --- the question
is do we have a self-consistent vision of how we will later do the
other stuff like renaming, changing column type, etc.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2008-08-08 00:32:05 Re: bug in prepared statements, alter table <8.3
Previous Message Andrew Gierth 2008-08-07 22:49:48 Re: bug in prepared statements, alter table <8.3