Re: narwhal and PGDLLIMPORT

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: Marco Atzeri <marco(dot)atzeri(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: narwhal and PGDLLIMPORT
Date: 2014-02-16 18:25:58
Message-ID: 29602.1392575158@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> On 2014-02-16 12:57:46 -0500, Tom Lane wrote:
>> I'm starting to get the feeling that we're going to have to admit
>> defeat and not try to use --disable-auto-import on cygwin builds.
>> That platform is evidently not capable of supporting it.

> Agreed. It's probably doable if somebody actually using cygwin
> themselves would invest a day or two and work on upstreaming the
> changes, but it looks painful to do indirectly.

Yeah, and I doubt that anybody in the Cygwin project is going to see
the point of maintaining such patches anyway. As Marco said, their
idea is to provide a Unix-ish platform as best they can, not adopt all
the worst features of Windows. I kinda wonder why they have declspec's
on the getopt variables at all.

>> We seem to be pretty nearly there on getting the MSVC and Mingw builds
>> to reliably complain about missing PGDLLIMPORTs, so maybe it's good
>> enough if those builds do it.

> Is there anything missing on that end?

I think it's all fixed, but I want to wait for another buildfarm cycle
just to be sure all the relevant critters are failing where we expect
them to and not somewhere else (like pltcl).

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2014-02-16 18:34:45 Re: narwhal and PGDLLIMPORT
Previous Message Andres Freund 2014-02-16 18:04:10 Re: narwhal and PGDLLIMPORT