From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
Cc: | Erik Rijkers <er(at)xs4all(dot)nl>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: trailing comment ghost-timing |
Date: | 2013-12-29 01:20:59 |
Message-ID: | 29569.1388280059@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> On 2013-12-24 12:27:59 -0500, Tom Lane wrote:
>> What I was proposing was that we do include comments in what we send,
>> as long as those comments are embedded in the statement text, not
>> on lines before it.
> The common way I've seen what I've described above done as is something
> like:
> /* File:path/to/some/file.whatever Function:foo::something()
> * Comment: Expensive, but that's ok!
> */
> SELECT here_comes FROM my WHERE some_sql;
> If I unerstood what you propose correctly, we'd now drop that comment,
> where we sent it before?
Yeah. But I just noticed that this would cause the regression test
results to change dramatically --- right now, most "-- comment" comments
get echoed to the output, and that would stop. So maybe it's not such
a great idea after all.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2013-12-29 01:55:24 | Re: Fix typo in src/backend/utils/mmgr/README |
Previous Message | Alvaro Herrera | 2013-12-29 01:08:30 | Re: truncating pg_multixact/members |