Re: Re: patch review : Add ability to constrain backend temporary file space

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Cédric Villemain <cedric(dot)villemain(dot)debian(at)gmail(dot)com>
Cc: Mark Kirkwood <mark(dot)kirkwood(at)catalyst(dot)net(dot)nz>, Tatsuo Ishii <ishii(at)postgresql(dot)org>, josh(at)agliodbs(dot)com, robertmhaas(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: patch review : Add ability to constrain backend temporary file space
Date: 2011-07-15 14:30:19
Message-ID: 29393.1310740219@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

=?ISO-8859-1?Q?C=E9dric_Villemain?= <cedric(dot)villemain(dot)debian(at)gmail(dot)com> writes:
>> On 15/07/11 14:57, Tatsuo Ishii wrote:
>>> Maybe we could add more info regarding current usage and requested
>>> amount in addition to the temp file limit value. I mean something
>>> like:
>>>
>>> ERROR: aborting due to exceeding temp file limit. Current usage 9000kB,
>>> requested size 1024kB, thus it will exceed temp file limit 10000kB.

> Remember that what will happens is probably:

> ERROR: aborting due to exceeding temp file limit. Current usage 8000kB,
> requested size 8008kB, thus it will exceed temp file limit 8kB.

> because temp file are increased by 8kb at once, rarely more

Yes. I think the extra detail Tatsuo proposes is useless and possibly
confusing. I don't object to stating the current limit, but the other
numbers are not likely to be helpful to anyone. (If we had some way of
knowing what the file would ultimately grow to if we allowed the query
to continue, that would be useful; but of course we don't know that.)

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2011-07-15 14:33:17 Re: ON COMMIT action not catalogued?
Previous Message MauMau 2011-07-15 14:03:11 Re: patch for distinguishing PG instances in event log