Re: PATCH: Allow empty targets in unaccent dictionary

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Abhijit Menon-Sen <ams(at)2ndQuadrant(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org, Mohammad Alhashash <alhashash(at)alhashash(dot)net>
Subject: Re: PATCH: Allow empty targets in unaccent dictionary
Date: 2014-07-01 02:06:30
Message-ID: 28979.1404180390@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Abhijit Menon-Sen <ams(at)2ndQuadrant(dot)com> writes:
> At 2014-06-30 15:19:17 -0400, tgl(at)sss(dot)pgh(dot)pa(dot)us wrote:
>> It's not unlikely that we want this patch *and* an improvement that
>> allows multi-character src strings

> I think it's enough to apply just this patch, but I wouldn't object to
> doing both if it were easy. It's not clear to me if that's true after a
> quick glance at the code, but I'll look again when I'm properly awake.

I went ahead and committed this patch, and also some further work to
fix the multicharacter-source problem. I took it on myself to make the
code issue warnings about misformatted lines, too.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Etsuro Fujita 2014-07-01 02:09:37 Re: inherit support for foreign tables
Previous Message Noah Misch 2014-07-01 01:46:26 Re: better atomics - v0.5