Re: Add support for logging the current role

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Stephen Frost <sfrost(at)snowman(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add support for logging the current role
Date: 2011-01-15 16:08:48
Message-ID: 28937.1295107728@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Fri, Jan 14, 2011 at 9:24 PM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>> What's your suggestion, then?

> If there's a practical way to add the requested escape, add it to the
> text format and leave reengineering the CSV format for another day.
> Yeah, I know that's not the most beautiful solution in the world, but
> we're doing engineering here, not theology.

Well, the original patch was exactly that. But I don't agree with that
approach; I think allowing the capabilities of text and CSV logs to
diverge significantly would be a mistake. If a piece of information is
valuable enough to need a way to include it in textual log entries,
then you need a way to include it in CSV log entries too. If it's not
valuable enough to do the work to support it in CSV, then we can live
without it.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2011-01-15 16:14:12 Re: We need to log aborted autovacuums
Previous Message Tom Lane 2011-01-15 15:54:49 Re: Streaming base backups