| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | KONDO Mitsumasa <kondo(dot)mitsumasa(at)lab(dot)ntt(dot)co(dot)jp>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Rajeev rastogi <rajeev(dot)rastogi(at)huawei(dot)com>, Mitsumasa KONDO <kondo(dot)mitsumasa(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Subject: | Re: Add min and max execute statement time in pg_stat_statement |
| Date: | 2014-04-07 20:19:58 |
| Message-ID: | 28799.1396901998@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> I just noticed that this patch not only adds min,max,stddev, but it also
> adds the ability to reset an entry's counters. This hasn't been
> mentioned in this thread at all; there has been no discussion on whether
> this is something we want to have, nor on whether this is the right API.
> What it does is add a new function pg_stat_statements_reset_time() which
> resets the min and max values from all function's entries, without
> touching the stddev state variables nor the number of calls. Note
> there's no ability to reset the values for a single function.
That seems pretty bizarre. At this late date, the best thing would
probably be to strip out the undiscussed functionality. It can get
resubmitted for 9.5 if there's a real use-case for it.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2014-04-07 20:24:45 | Re: CREATE FOREIGN TABLE ( ... LIKE ... ) |
| Previous Message | Andres Freund | 2014-04-07 20:03:02 | Re: Why is it not sane to pass ExecStoreTuple(shouldFree=true) for tuples point into buffers |