"Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov> writes:
> At a minimum, it might be good to qualify the comment in htup.h and
> add a comment where there is an exception. This can be startling in
> a debugger if you don't know that the comment isn't really true.
> (And I've found another place where t_tableOid isn't set, but it is
> apparently benign; that's without an exhaustive search.)
> I could put forward a comment-only patch per the above if there are
> no objections.
I don't want to put weasel wording into the comment. If you're bothered
by the discrepancy then we should fix the code to initialize all the
struct fields.
regards, tom lane