Re: "COPY foo FROM STDOUT" and ecpg

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: "COPY foo FROM STDOUT" and ecpg
Date: 2013-02-26 16:23:34
Message-ID: 2841.1361895814@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> writes:
> While looking at Fujita Etsuro's patch to allow copy to/from a shell
> command, I noticed that the grammar currently allows these:

> COPY foo FROM STDOUT
> COPY foo TO STDIN

> In other words, STDIN and STDOUT can be used completely interchangeably.
> However, the ecpg grammar is more strict about that:

> ERROR: COPY TO STDIN is not possible

> Any particular reason for ecpg to check that, while the backend doesn't
> care? I think we should just remove those checks from the ecpg grammar.

Agreed, but your draft patch doesn't do that completely. It should only
make tests that correspond to what the error message says. (I assume
the backend will bounce the other cases at some post-grammar stage.)

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2013-02-26 16:25:56 Re: pg_xlogdump compile error
Previous Message Dimitri Fontaine 2013-02-26 16:23:01 Re: pg_xlogdump