Re: pq_setkeepalives* functions

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Jaime Casanova <jcasanov(at)systemguards(dot)com(dot)ec>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pq_setkeepalives* functions
Date: 2010-03-13 16:44:21
Message-ID: 2839.1268498661@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Tom Lane wrote:
>> This makes the function *not* like the other two, rather than
>> improving consistency.

> Well, it makes it like some of the existing functions, but not like
> others. This applied patch fixes them all.

This is making things worse, not better. You have just changed the
behavior, and not in a good way. Formerly these were no-ops on
a unix socket connection, and now they can throw errors.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Merlin Moncure 2010-03-13 16:55:45 Re: Dyamic updates of NEW with pl/pgsql
Previous Message Bruce Momjian 2010-03-13 16:40:46 Re: pq_setkeepalives* functions