Re: guc patch: Make variables fall back to default values

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Joachim Wieland <joe(at)mcknight(dot)de>
Cc: Gregory Stark <stark(at)enterprisedb(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-patches(at)postgresql(dot)org
Subject: Re: guc patch: Make variables fall back to default values
Date: 2007-03-13 15:52:38
Message-ID: 2819.1173801158@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Joachim Wieland <joe(at)mcknight(dot)de> writes:
> On Tue, Mar 13, 2007 at 11:08:52AM -0400, Tom Lane wrote:
>> My point here that you shouldn't be using var->group to make any
>> semantic choices. That's supposed to be a label for user convenience,
>> nothing else.

> Then what is the criterion to tell what is a custom variable and what isn't?

Why do you need to tell that? IMHO, once the DefineCustomFoo function
has been executed, it should be exactly like any other variable (other
than having a funny name).

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Joachim Wieland 2007-03-13 16:22:20 Re: guc patch: Make variables fall back to default values
Previous Message Joachim Wieland 2007-03-13 15:31:12 Re: guc patch: Make variables fall back to default values