Re: Compression of full-page-writes

Sameer Thakur <samthakur74(at)gmail(dot)com> writes:
> I was trying to check WAL reduction using this patch on latest available git
> version of Postgres using JDBC runner with tpcc benchmark.
> patching_problems.txt
> <http://postgresql.1045698.n5.nabble.com/file/n5803482/patching_problems.txt>
> I did resolve the patching conflicts and then compiled the source, removing
> couple of compiler errors in process. But the server crashes in the compress
> mode i.e. the moment any WAL is generated. Works fine in 'on' and 'off'
> mode.
> Clearly i must be resolving patch conflicts incorrectly as this patch
> applied cleanly earlier. Is there a version of the source where i could
> apply it the patch cleanly?

If the patch used to work, it's a good bet that what broke it is the
recent pgindent run:
http://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=0a7832005792fa6dad171f9cadb8d587fe0dd800

It's going to need to be rebased past that, but doing so by hand would
be tedious, and evidently was error-prone too. If you've got pgindent
installed, you could consider applying the patch to the parent of
that commit, pgindent'ing the whole tree, and then diffing against
that commit to generate an updated patch.
See src/tools/pgindent/README for some build/usage notes about pgindent.

regards, tom lane