Re: A bug in scan.l

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Gokulakannan Somasundaram <gokul007(at)gmail(dot)com>
Cc: pgsql-hackers list <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: A bug in scan.l
Date: 2009-09-02 14:35:01
Message-ID: 2751.1251902101@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Gokulakannan Somasundaram <gokul007(at)gmail(dot)com> writes:
> Well, i am at a very beginner level with Flex. I could see how flex works
> with it even if it is a ambiguity. Since it matches the rule with the
> maximum text and we don't allow a new line character in the rule, it works
> fine. Even in LL(1), it works fine, but throws warnings. So i just thought
> of suggesting to remove the ambiguity.

Well, that whole rule is only there for implementation-specific reasons
--- a flex scanner is faster if it doesn't need to back up. You might
be best off to just remove the anti-backup rules in the LL translation.

> But do we need to allow comments as part of unicode escapes?

If they're like normal strings, yes.

regression=# select 'this is' -- comment
regression-# ' one string';
?column?
--------------------
this is one string
(1 row)

Don't blame us, blame the SQL committee. This was not one of their
better ideas IMO.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-09-02 14:46:54 Re: window functions maybe bug
Previous Message Greg Stark 2009-09-02 14:23:13 Re: Linux LSB init script