| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Rod Taylor <rbt(at)rbt(dot)ca> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Transaction safe Truncate |
| Date: | 2002-11-15 23:29:15 |
| Message-ID: | 2733.1037402955@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Rod Taylor <rbt(at)rbt(dot)ca> writes:
> I'd like to split cluster_rel() in cluster.c into 2 functions at line
> 174. The permission checks, locking, etc will remain in cluster_rel().
> The bottom half will be turned into a function called
> rebuild_rel(tableOid Oid, indexOid Oid, dataCopy bool).
I just finished fixing the division of labor between TruncateRelation
and heap_truncate. Please don't break it merely to avoid rearranging
code in cluster.c. Actually, I'd argue that cluster should adopt
truncate's code layout, not vice versa.
> I'll also move TruncateRelation into cluster.c.
You could leave it where it is and just move heap_truncate.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephan Szabo | 2002-11-15 23:38:46 | Re: RI_FKey_check: foreign key constraint blocks parallel |
| Previous Message | Tom Lane | 2002-11-15 22:54:39 | char(n) to varchar or text conversion should strip trailing spaces |