| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Craig Ringer <craig(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: PGDLLEXPORTing all GUCs? |
| Date: | 2014-05-07 14:29:36 |
| Message-ID: | 27201.1399472976@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> On 2014-05-07 09:35:06 -0400, Tom Lane wrote:
>> Craig Ringer <craig(at)2ndquadrant(dot)com> writes:
>>> Is there any reason _not_ to PGDLLEXPORT all GUCs, other than cosmetic
>>> concerns?
>> That seems morally equivalent to "is there a reason not to make every
>> static variable global?".
> I think what Craig actually tries to propose is to mark all GUCs
> currently exported in headers PGDLLIMPORT.
There are few if any GUCs that aren't exposed in headers, just so that
guc.c can communicate with the owning modules. That doesn't mean that
we want everybody in the world messing with them.
To my mind, we PGDLLEXPORT some variable only after deciding that yeah,
we're okay with having third-party modules touching that. Craig's
proposal is to remove human judgement from that process.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2014-05-07 14:31:07 | Re: proposal: Set effective_cache_size to greater of .conf value, shared_buffers |
| Previous Message | Craig Ringer | 2014-05-07 14:26:21 | Re: PGDLLEXPORTing all GUCs? |