Re: [COMMITTERS] pgsql: Replace duplicate_oids with Perl implementation

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: [COMMITTERS] pgsql: Replace duplicate_oids with Perl implementation
Date: 2013-11-10 21:07:39
Message-ID: 2701.1384117659@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> On 10/11/13 3:57 AM, Tom Lane wrote:
>> What about unused_oids?

> We are not planning to put unused_oids in to the main build path, so
> there is much less of a need to make it more portable or robust.

> Also, as we have just (re-)learned, you cannot rely on /usr/bin/perl
> being there, so rewriting unused_oids in Perl would arguably make it
> less usable.

I'd argue the opposite --- the existing shell-script version is entirely
useless to developers running on Windows, while they could use a Perl
version. Also, we've pretty much locked in the assumption that developers
will have Perl.

I've not actually looked at Andrew's script yet, but if it works I think
we should replace the shell script.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Geoghegan 2013-11-10 21:16:24 Re: [COMMITTERS] pgsql: Replace duplicate_oids with Perl implementation
Previous Message Peter Eisentraut 2013-11-10 19:55:26 pgsql: Fix whitespace issues found by git diff --check, add gitattribut

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2013-11-10 21:16:24 Re: [COMMITTERS] pgsql: Replace duplicate_oids with Perl implementation
Previous Message Peter Eisentraut 2013-11-10 19:55:26 pgsql: Fix whitespace issues found by git diff --check, add gitattribut